[PATCH][SPARC] missing membar in niagara2_memcpy

David Miller davem@davemloft.net
Thu May 15 17:27:00 GMT 2014


From: jose.marchesi@oracle.com (Jose E. Marchesi)
Date: Thu, 15 May 2014 18:14:44 +0200

> The following patch prevents stores made before calling memcpy to
> overlap with the block stores in niagara2_memcpy.
> 
> Tested on an Athena machine (sparc64x) running sparc64-*-linux-gnu.
> No new warnings triggered by the patch.
> No regressions detected.

Does it really fix anything?

Are these crashes or data corruptions or thread data visibilty issues
that you've seen in practice and are cured by this change?

The member is extremely expensive and I avoided it intentionally.



More information about the Libc-alpha mailing list