[PATCH] fix nl_langinfo with static linking

Aurelien Jarno aurelien@aurel32.net
Tue May 6 21:10:00 GMT 2014


On Tue, May 06, 2014 at 02:04:15PM -0700, Roland McGrath wrote:
> > +	($(objpfx)tst-langinfo.out): Redirect output.
> 
> Mention use of $(evaluate-test) too.

$(evaluate-test) is not something new for tst-langinfo.out, it appears
there because the way the diff is done by git.

> > +    default:                   /* Should be impossible.  */
> > +      return (char *) "";
> 
> Make this an assert or abort rather than having the library function return
> the user error indication for a case that is an implementation bug.
> 
> Otherwise looks fine to me (with BZ# added).

Ok, thanks for the review.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net



More information about the Libc-alpha mailing list