[patch] Finish __builtin_expect -> __glibc_{un}likely cleanup in elf/dl-load.c

Ondřej Bílka neleai@seznam.cz
Thu Mar 27 17:31:00 GMT 2014


On Thu, Mar 27, 2014 at 09:42:54AM -0700, Paul Pluzhnikov wrote:
> 
> >> @@ -2230,7 +2228,7 @@ _dl_map_object (struct link_map *loader, const char *name,
> >>
> >>  #ifdef USE_LDCONFIG
> >>        if (fd == -1
> >> -       && (__builtin_expect (! (mode & __RTLD_SECURE), 1)
> >> +       && (__glibc_likely ((mode & __RTLD_SECURE) == 0)
> >>             || ! INTUSE(__libc_enable_secure))
> >>         && __glibc_likely (GLRO(dl_inhibit_cache) == 0))
> >>       {
> >
> > Extra parens here.
> 
> Are there? I don't see them :-(
> 
Never mind, when I saw that I forgotten that & has weird precedence.



More information about the Libc-alpha mailing list