[PATCH roland/Versions.def] Get rid of Versions.def source file
Carlos O'Donell
carlos@redhat.com
Tue Mar 25 21:55:00 GMT 2014
On 03/21/2014 06:53 PM, Roland McGrath wrote:
>> No, it worked previously - the point is that GLIBC_2.2.5 is only mentioned
>> in Versions files (sysdeps/unix/bsd/Versions
>> sysdeps/unix/sysv/linux/x86_64/Versions mach/Versions hurd/Versions) that
>> aren't used for MIPS, but used in SHLIB_COMPAT in files that are used for
>> MIPS.
>
> Oh, I see. Before Versions.def had the union of all sysdeps/.../Versions
> files in the source tree. Now the generated file gets only the union of
> all Versions files actually selected in the current configuration. Someone
> (like Carlos when reviewing my change ;->) should check what Versions.def
> items were lost in some configuration. But I guess the ones that matter
> will come out in usual testing now with -Wundef.
For the record I only tested on x86*, and not on other targets.
This particular breakage did not occur to me, and I didn't
notice it in my review. I had also forgotten that we had GCC_*
versions in glibc as part of our ABI compatibility as the
implementation. That certainly complicates assembling a Version.def
file automatically.
Cheers,
Carlos.
More information about the Libc-alpha
mailing list