[PATCH roland/Versions.def] Get rid of Versions.def source file
Joseph S. Myers
joseph@codesourcery.com
Fri Mar 21 22:46:00 GMT 2014
On Fri, 21 Mar 2014, Roland McGrath wrote:
> Technically it doesn't matter. Practically, as long as it gets a comment
> explaining its purpose, it's unlikely to cause a maintenance headache
> wherever it is. What seems most sensible is for it to be in a Versions
> file in the same directory as the (first) source file that causes the need
> for it. That would be sysdeps/generic/ at the moment, but I don't know any
> reason why those files (or any files other than headers) shouldn't be in
> elf/ (or whatever appropriate subdir) rather than sysdeps/generic/. So
> maybe first clean things up by moving the source files and Makefile bits to
> elf/, and then add GLIBC_2.2.5 to elf/Versions. (Actually it doesn't
> matter which order those are done in, but cleanup-first is usually the best
> way to avoid cleanup-forgotten.)
I've filed bug 16737 for moving sources and Makefile logic.
> I'm a bit confused about the situation on mips. Was its check-abi already
> broken before my Versions.def change? The intent of that change was that
> it have no material effect on any build output.
No, it worked previously - the point is that GLIBC_2.2.5 is only mentioned
in Versions files (sysdeps/unix/bsd/Versions
sysdeps/unix/sysv/linux/x86_64/Versions mach/Versions hurd/Versions) that
aren't used for MIPS, but used in SHLIB_COMPAT in files that are used for
MIPS.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list