[PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning

Roland McGrath roland@hack.frob.com
Thu Mar 20 17:52:00 GMT 2014


> On Tue, 18 Mar 2014, Roland McGrath wrote:
> 
> > I haven't examined that particular set of macros, so I don't have something
> > specific in mind.  It's just the general rule that we should organize our
> > macros (including wholesale reshuffling of what we have today, if need be)
> > so that every use under our control if typo-proof.
> 
> Typo-proofing also provides another case for replacing the __need_* 
> scheme, as I suggested in 
> <https://sourceware.org/ml/libc-alpha/2012-08/msg00510.html> and 
> <https://sourceware.org/ml/libc-alpha/2012-11/msg00045.html>, so that we 
> do
> 
> #include <bits/time_t.h>
> 
> instead of
> 
> #define __need_time_t
> #include <time.h>
> 
> (the former being typo-proof, the latter not).

I didn't recall you suggesting that, but it's been on my list for some
time.  (I think we should use a convention other than plain bits/, but
that's just trivia.)



More information about the Libc-alpha mailing list