[PATCH] [ARM] Add fenv test support for targets which don't have FP traps

Joseph S. Myers joseph@codesourcery.com
Wed Mar 19 17:40:00 GMT 2014


On Wed, 19 Mar 2014, Wilco wrote:

> +/* Indicate whether the given exception trap(s) can be enabled
> +   in feenableexcept.  All traps are supported unless overridden.  */
> +#ifndef EXCEPTION_ENABLE_SUPPORTED
> +# define EXCEPTION_ENABLE_SUPPORTED(EXCEPT)			\
> +   (EXCEPTION_TESTS_float || EXCEPTION_TESTS_double)
> +#endif

I think the comment needs to make the definition clearer (that a nonzero 
value means the traps are definitely supported, but a zero value means 
they might or might not be supported and this is determined at runtime 
with enabling traps being allowed to fail).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list