[PATCH] Fix -Wundef warnins for __FP_FAST_FMA*

Mike Frysinger vapier@gentoo.org
Wed Mar 19 05:42:00 GMT 2014


On Tue 18 Mar 2014 15:36:18 Roland McGrath wrote:
> The context of predefines usually means that the base thing we're looking
> at provided by the compiler has to be tested with #ifdef.  (For any future
> predefines, we should work with compiler folks to suggest that new things
> follow the #if-friendly pattern of macros always defined to either 0 or 1
> rather than the typo-prone pattern of sometimes-defined macros.)

i like the sentiment, but i'm not sure about the practicality.  how do you go 
about deciding whether a macro should always be defined ?  the set of all 
possible defines gcc might create depending on configuration/target settings ?  
seems like you'd easily generate a crap ton of noisy defines and blow past the 
point of usefulness ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140319/6a42cb56/attachment.sig>


More information about the Libc-alpha mailing list