PLEASE FIX NOW! make check-abi exits zero on failure

[Carlos O'Donell]

On 03/17/2014 06:50 PM, Roland McGrath wrote:
> Whatever changes whoever made need to be fixed or reverted right away.
> 'make check-abi' exits with status zero when there are failures.
> This is unacceptable.
> 
> If the people who broke this don't fix this it quickly, I'll start randomly
> reverting changes that look related.

Not for me?

[carlos@koi glibc-wundef]$ make -k check
...
FAIL: conform/POSIX2008/cpio.h/conform
FAIL: conform/UNIX98/cpio.h/conform
FAIL: conform/UNIX98/fmtmsg.h/conform
FAIL: conform/XOPEN2K/cpio.h/conform
FAIL: conform/XOPEN2K/fmtmsg.h/conform
FAIL: conform/XOPEN2K8/cpio.h/conform
FAIL: conform/XOPEN2K8/fmtmsg.h/conform
FAIL: conform/XPG3/cpio.h/conform
FAIL: conform/XPG4/cpio.h/conform
FAIL: conform/XPG4/fmtmsg.h/conform
FAIL: elf/check-abi-ld
Summary of test results:
     11 FAIL
   1690 PASS
    122 XFAIL
      3 XPASS
make[1]: *** [tests] Error 1
make[1]: Target `check' not remade because of errors.
make[1]: Leaving directory `/home/carlos/src/glibc-wundef'
make: *** [check] Error 2
[carlos@koi glibc-wundef]$ echo $?
2

Make sure you have d6fe5e582d4e4bb339f55bc6369eaca0c52e527c?

Cheers,
Carlos.