[PATCH 2/2][BZ #16640] Remove strtok assembly implementation.
Joseph S. Myers
joseph@codesourcery.com
Thu Mar 13 12:53:00 GMT 2014
On Thu, 13 Mar 2014, Carlos O'Donell wrote:
> Are you saying then that the resulting code generated with gcc 4.4
> is approximately the same performance as that generated with a
> newer gcc, both of which are 2-4x faster than the assembly
> implementation?
>
> If that's the case then please commit your patch.
Carlos, you appear to have omitted an important qualification here. As
Mike noted in
<https://sourceware.org/ml/libc-alpha/2014-03/msg00221.html>, there needs
to be a proper justification for *machines without SSE4.2*. Without such
a justification showing this change does not regress performance on such
hardware, we don't have consensus for this patch.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list