[PATCH] Multiarch optimization for strncat on PowerPC64
R Vidya
vidya@linux.vnet.ibm.com
Thu Mar 6 17:44:00 GMT 2014
Addressed comments.
On Thursday 06 March 2014 06:08 PM, Adhemerval Zanella wrote:
> On 06-03-2014 07:34, R Vidya wrote:
>> +#define FRAMESIZE (FRAME_MIN_SIZE+112)
> Your implementation does not uses 112 bytes of stack, I think you mean plus 3 (the r29, r30, r31)
> you save.
>
>> +
>> +L(a4):
>> + cmpdi r29, 0 /* if "n" is already zero ; we skip */
>> + beq+ L(align4align)
>> +
>> + mtctr r29 /* process left over bytes in "n" */
>> +unaligned1:
> Missing L(...) on this label.
>
>> +
>> +L(a8):
>> + cmpdi r29, 0 /* if "n" is already zero ; we skip */
>> + beq+ L(align8align)
>> +
>> + mtctr r29 /* process left over bytes in "n" */
>> +unaligned0:
> Missing L(...) on this label.
>
> Besides that, it is ok.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Multiarch-optimization-for-strncat-on-ppc64-and-ppc6.patch
Type: text/x-patch
Size: 16306 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140306/4c866545/attachment.bin>
More information about the Libc-alpha
mailing list