[PATCH 2/2][BZ #16640] Remove strtok assembly implementation.

Ondřej Bílka neleai@seznam.cz
Thu Mar 6 16:32:00 GMT 2014


On Thu, Mar 06, 2014 at 11:20:13AM -0500, Carlos O'Donell wrote:
> On 02/27/2014 07:42 AM, Ondřej Bílka wrote:
> > As followup this patch removes strtok assembly implementation as it is
> > around 2-4 times slower on sse4_2 capable machines which is a majority,
> > as previous benchtest demonstrated.
> > 
> > You could try to gain some cycles on older machines by using ifuncs but
> > is a strtok important enough to complicate matters?
> > 
> > OK to commit?
> > 
> > 	* sysdeps/i386/i686/strtok.S: Remove.
> > 	* sysdeps/i386/i686/strtok_r.S: Likewise.
> > 	* sysdeps/i386/strtok.S: Likewise.
> > 	* sysdeps/i386/strtok_r.S: Likewise.
> > 	* sysdeps/x86_64/strtok.S: Likewise.
> > 	* sysdeps/x86_64/strtok_r.S: Likewise.
> 
> Is this still the case with the oldest compiler we support?
> 
I do not understand what are you reffering to.



More information about the Libc-alpha mailing list