[PATCH] Multiarch optimization for strncat on PowerPC64

Adhemerval Zanella azanella@linux.vnet.ibm.com
Thu Mar 6 12:38:00 GMT 2014


On 06-03-2014 07:34, R Vidya wrote:
> +#define	FRAMESIZE	(FRAME_MIN_SIZE+112)

Your implementation does not uses 112 bytes of stack, I think you mean plus 3 (the r29, r30, r31)
you save.

> +
> +L(a4):
> +	cmpdi r29, 0			/* if "n" is already zero ; we skip  */
> +	beq+ L(align4align)
> +
> +	mtctr r29			/* process left over bytes in "n"  */
> +unaligned1:

Missing L(...) on this label.

> +
> +L(a8):
> +	cmpdi r29, 0			/* if "n" is already zero ; we skip */
> +	beq+ L(align8align)
> +
> +	mtctr r29			/* process left over bytes in "n"  */
> +unaligned0:

Missing L(...) on this label.

Besides that, it is ok.



More information about the Libc-alpha mailing list