[PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.

Carlos O'Donell carlos@redhat.com
Thu Mar 6 06:48:00 GMT 2014


On 03/05/2014 06:31 PM, Pedro Alves wrote:
> I happened to skim this patch for some reason, and
> noticed ...
> 
> On 03/05/2014 05:11 AM, Carlos O'Donell wrote:
>> +#if _STACK_GROWS_DOWN
>>    iattr->stackaddr = (char *) stackaddr + stacksize;
>> +#else
>> +  iattr->stackaddr = (char *) stackaddr;
>> +#endif
>>    iattr->flags |= ATTR_FLAG_STACKADDR;
> 
> Used #if here.
> 
>> +#if _STACK_GROWS_DOWN
>>    iattr->stackaddr = (char *) stackaddr + stacksize;
>> +#else
>> +  iattr->stackaddr = (char *) stackaddr;
>> +#endif
>>    iattr->flags |= ATTR_FLAG_STACKADDR;
> 
> Used #if here.
> 
>>    /* Store the result.  */
>> +#ifdef _STACK_GROWS_DOWN
>>    *stackaddr = (char *) iattr->stackaddr - iattr->stacksize;
>> +#else
>> +  *stackaddr = (char *) iattr->stackaddr;
> 
> Used #ifdef here -- any particular reason for that?

None. Just sloppy. I'll fix that. Thanks for the review!

Cheers,
Carlos.



More information about the Libc-alpha mailing list