[PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.

Carlos O'Donell carlos@redhat.com
Wed Mar 5 15:04:00 GMT 2014


On 03/05/2014 09:55 AM, Joseph S. Myers wrote:
> On Wed, 5 Mar 2014, Carlos O'Donell wrote:
> 
>> Can't impact any other targets because of the conditionals.
> 
> For this sort of thing I suggest comparing before-and-after disassembly of 
> the installed shared libraries on some other system (e.g. x86_64) to 
> confirm there are no typos making it affect other systems.  I think 
> _STACK_GROWS_* changes can be considered obvious if (a) the text after 
> preprocessing is intended to be unchanged on _STACK_GROWS_DOWN systems, 
> (b) it's confirmed that the disassembly of the installed shared libraries 
> is unchanged (modulo anything arising from different line numbers in 
> assertions) and (c) it's confirmed it does have the desired effect on 
> hppa.  That should cover most of these changes.
> 

I'm OK with (a), (b) and (c).

I'll do that and then start committing them.

Cheers,
Carlos.



More information about the Libc-alpha mailing list