[PATCH roland/Wundef] Compile with -Wundef.

[Thomas Schwinge]

Hi!

On Fri, 28 Feb 2014 15:28:05 -0800 (PST), Roland McGrath <roland@hack.frob.com> wrote:
> --- a/sysdeps/mach/hurd/i386/tls.h
> +++ b/sysdeps/mach/hurd/i386/tls.h
> @@ -26,6 +26,7 @@
>  /* The TCB can have any size and the memory following the address the
>     thread pointer points to is unspecified.  Allocate the TCB there.  */
>  #define TLS_TCB_AT_TP	1
> +#define TLS_TCB_AT_TP	0

:-) Hmm?  (Should that have been TLS_DTV_AT_TP, I think?)


Also, not relevant for Hurd but for NPTL: don't all »#ifdef
TLS_TCB_AT_TP« need to be adapted now?  And, all the instances of »#error
"Either TLS_TCB_AT_TP or TLS_DTV_AT_TP must be defined"« are not longer
appropriate in this wording, too.


Generally, of course, thumbs up for stricter compile-time checks.


Grüße,
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140303/251e1b20/attachment.sig>