[PATCH v2] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
Chris Metcalf
cmetcalf@tilera.com
Fri Jun 27 20:27:00 GMT 2014
On 6/27/2014 1:13 PM, Siddhesh Poyarekar wrote:
> I've moved the macro definition to memcopy.h with tile overriding the
> definition in its memcopy.h. This also allows us to get rid of the
> tile-specific memmove.c. The tile bit is untested, so I'll need Chris
> to verify that it doesn't cause any problems. The code is unchanged
> on x86_64.
>
> Siddhesh
>
> * sysdeps/generic/memcopy.h: Define MEMCPY_OK_FOR_FWD_MEMMOVE.
> * sysdeps/tile/memcopy.h: Redefine MEMCPY_OK_FOR_FWD_MEMMOVE.
> * sysdeps/tile/tilegx/memmove.c: Remove file.
The problem with this is that tilepro's memmove.c can't use the optimization,
just tilegx, thus the placement in sysdeps/tile/tilegx/memmove.c. So with an
#ifdef __tilegx__, and copying in the comment from the old memmove.c,
this would seem to be OK.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
More information about the Libc-alpha
mailing list