[PATCH roland/nptl-mips] MIPS: Consolidate NPTL/non versions of vfork
Joseph S. Myers
joseph@codesourcery.com
Fri Jun 27 17:45:00 GMT 2014
On Wed, 25 Jun 2014, Roland McGrath wrote:
> > This appears to be a copy of the clone patch, not a vfork patch....
>
> Oops. The branch had the right thing.
>
> > The generic pt-vfork.c gives a #error for the non-IFUNC case. The AArch64
> > version (which I now notice is returning void not pid_t, which looks
> > suspicious to me) won't work for MIPS n32/n64 - for the 64-bit ABIs, gp
> > ($28) is callee-saved, and so the attempt at a tail call involves saving
> > the caller's value and computing a new value, then restoring the old value
> > of gp after the non-tail call before returning. It might work for o32,
> > but it seems simpler just to #include the alpha version for all three
> > ABIs.
>
> OK. I've updated the branch to do that. The new patch is below.
This patch is OK.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list