[PATCH 1/25] Remove nested functions: crypt/md5-crypt.c

Siddhesh Poyarekar siddhesh@redhat.com
Tue Jun 3 11:12:00 GMT 2014


On Tue, Jun 03, 2014 at 12:28:35PM +0400, Konstantin Serebryany wrote:
> On Mon, Jun 2, 2014 at 10:08 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> > On Mon, Jun 02, 2014 at 08:50:51AM +0400, Konstantin Serebryany wrote:
> >> Any comment on this patch?
> >
> > It results in a bunch of build warnings with gcc.  Please fix those.
> Indeed so, needed one extra include. Fixed, please check the new patch.
> 
> Did you just see the warnings with your eyes, or do you use a special
> configure switch or some such to turn them into errors?
> 

TBH I just happened to see it when I was pulling in your patch.  I
noticed a warning I had introduced earlier and then the warnings you
introduced :)

I have pushed your patch now.

Thanks,
Siddhesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140603/c67533d6/attachment.sig>


More information about the Libc-alpha mailing list