[PATCH 1/25] Remove nested functions: crypt/md5-crypt.c

[Konstantin Serebryany]

Any comment on this patch?

On Thu, May 22, 2014 at 7:14 PM, Konstantin Serebryany
<konstantin.s.serebryany@gmail.com> wrote:
> On Thu, May 22, 2014 at 6:59 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> On Tue, May 20, 2014 at 06:23:40PM +0400, Konstantin Serebryany wrote:
>>> 2014-05-20  Kostya Serebryany  <konstantin.s.serebryany@gmail.com>
>>>
>>>         * crypt/md5-crypt.c (__md5_crypt_r): Remove a nested function.
>>>         (b64_from_24bit): New function.
>>>
>>
>> I have pushed this (and the formatting fix) now.
>
> Excellent, thanks!
> Here is the next patch with (hopefully) correct tabs:
>
> 2014-05-22  Kostya Serebryany  <konstantin.s.serebryany@gmail.com>
>
>         * crypt/crypt-private.h: Include ufc-crypt.h.
>         (__b64_from_24bit): Declare extern.
>         * crypt/crypt_util.c(__b64_from_24bit): New function.
>         (b64t): New static const variable.
>         * crypt/md5-crypt.c (b64_from_24bit): Remove function.
>         (b64t): Remove variable.
>         (__md5_crypt_r): Replace b64_from_24bit with __b64_from_24bit.
>         * crypt/sha256-crypt.c: Include crypt-private.h.
>         (b64t): Remove variable.
>         (__sha256_crypt_r): Remove b64_from_24bit and replace
>         with __b64_from_24bit.
>         * crypt/sha512-crypt.c: Likewise.
>
>
>
>
>
>
>
>>
>> Siddhesh