[PATCH v1.1] Deduplicate resolv/nss_dns/dns-host.c

Allan McRae allan@archlinux.org
Fri Jul 4 00:41:00 GMT 2014


On 15/02/14 21:39, Ondřej Bílka wrote:
> On Fri, Feb 14, 2014 at 12:25:51PM -0500, Mike Frysinger wrote:
>> On Thursday, February 13, 2014 13:38:12 Ondřej Bílka wrote:
>>> Hi, when reviewing Andreas patch I noticed duplicated code. One way to
>>> improve that is jump to exit logic. A second possibility would be put
>>>  gaih_getanswer into a else block. What do you prefer?
>>
>> i don't mind either, but i think generally the preference is to avoid goto 
>> when easily possible.  so in this case, use the else.
>> -mike
> 
> OK, patch for this is following. It should cover one extra possibility when
> __libc_res_nsearch fails and allocates separate buffer.
> 
> 	* resolv/nss_dns/dns-host.c (_nss_dns_gethostbyname4_r): Remove
> 	duplicate code
> 

Ondřej: This was committed without a ChangeLog entry.  Can you insert
one in the appropriate place.

Thanks,
Allan



More information about the Libc-alpha mailing list