[PATCH] un-nest findidx()

Konstantin Serebryany konstantin.s.serebryany@gmail.com
Thu Jul 3 13:01:00 GMT 2014


On Thu, Jul 3, 2014 at 4:26 PM, Andreas Schwab <schwab@suse.de> wrote:
> Konstantin Serebryany <konstantin.s.serebryany@gmail.com> writes:
>
>> On Thu, Jul 3, 2014 at 4:06 PM, Andreas Schwab <schwab@suse.de> wrote:
>>> Konstantin Serebryany <konstantin.s.serebryany@gmail.com> writes:
>>>
>>>>         (FCT): change type of 'extra' to wint_t;
>>>
>>> Why do you need this change?
>> To avoid warnings about different types of argument and parameter
>
> But why do you have that conflict in the first place?  You must use the
> type of the object in the end.

There are multiple uses of findidxwc. Some were using int32_t* for
'extra', some where using wint_t*
(e.g. see USTRING_TYPE in wcsmbs/wcscoll.c).
When un-nesting findidxwc we have to chose just one type. I chose
wint_t because otherwise the change would have been larger.

--kcc

>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."



More information about the Libc-alpha mailing list