[PATCH] Fix -Wundef warning on PAGE_COPY_THRESHOLD

Ondřej Bílka neleai@seznam.cz
Tue Jul 1 12:32:00 GMT 2014


On Tue, Jul 01, 2014 at 05:50:57PM +0530, Siddhesh Poyarekar wrote:
> The PAGE_COPY_THRESHOLD macro is meant to be overridden by
> architecture-specific pagecopy.h, but it is currently done only by
> mach; all other architectures use the default.  Check to see if the
> macro is defined in addition to whether it is set to a non-zero value.
> 
> Verified that the generated code is unchanged on x86_64.
> 
> Siddhesh
> 
> 	* sysdeps/generic/pagecopy.h: Also check if
> 	PAGE_COPY_THRESHOLD is defined.
> 
> ---
>  sysdeps/generic/pagecopy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sysdeps/generic/pagecopy.h b/sysdeps/generic/pagecopy.h
> index 2c35b71..2862270 100644
> --- a/sysdeps/generic/pagecopy.h
> +++ b/sysdeps/generic/pagecopy.h
> @@ -39,7 +39,7 @@
>  */
>  
>  
> -#if PAGE_COPY_THRESHOLD
> +#if defined PAGE_COPY_THRESHOLD && PAGE_COPY_THRESHOLD
>  
>  #include <assert.h>
>  
> -- 
> 1.9.3
> 

looks ok.



More information about the Libc-alpha mailing list