[PING][PATCH] stdlib/tst-strtod-overflow: Bump timeout up yet more

Will Newton will.newton@linaro.org
Tue Jul 1 11:13:00 GMT 2014


On 1 July 2014 12:04, Maciej W. Rozycki <macro@codesourcery.com> wrote:
> On Mon, 30 Jun 2014, Adhemerval Zanella wrote:
>
>> >>  In our routine testing I observed that stdlib/tst-strtod-overflow is very
>> >> slow, especially on targets using soft-float or QEMU (where soft-float is
>> >> used internally), enough to time out even on slow boards we have that have
>> >> TIMEOUTFACTOR already bumped from the default of 1 up to 75.
>> >>
>> >>  No other test case requires such a long timeout -- all the other
>> >> succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on
>> >> these boards.  As such I think it's counter-productive to require
>> >> TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as
>> >> the value affects overall testing duration where there are test cases that
>> >> genuinely time out due to a defect.  Therefore I propose the following
>> >> change that makes stdlib/tst-strtod-overflow pass on these slow boards
>> >> with TIMEOUTFACTOR of 75.
>> >  Ping!
>> >
>> I don't have any objection to the patch, the explanation seems fair enough.
>
>  Thanks for your input.  Any other comments, anyone, or shall I treat it
> as the consensus?

The change looks ok to me too.

-- 
Will Newton
Toolchain Working Group, Linaro



More information about the Libc-alpha mailing list