[PATCH][BZ #16046] Static dlopen correction fallout fixes

[Roland McGrath]

>  Thinking more about the test case I have concluded that maybe a 
> path-of-least-resistance check like below would do.  It verifies that 
> there's exactly one link map whose file name is null, as is the case with 
> the main executable only.  This approach may not be particularly robust, 
> but it does cover what BZ #16046 is about.

It's a start.  Ideal would be to look at all the places you had to change
and figure out what user-visible effects those changes had.

> +static int count;

Why have a static instead of passing the address of a local in the void *?

> +static int
> +callback (struct dl_phdr_info *info, size_t size, void *data)
> +{
> +  if (!*info->dlpi_name)

No implicit Boolean coercion please: (info->dlpi_name[0] == '\0') is the
canonical way to write this expression.

> +int
> +main(void)

Space before paren.

It's also good to have a comment simply explaining what it's verifying,
even though it is fairly obvious in this case.


Thanks,
Roland