Fix math/test-fpucw-*.c for sysdeps test-fpucw.c overrides

Siddhesh Poyarekar siddhesh@redhat.com
Thu Jan 16 03:54:00 GMT 2014


On Wed, Jan 15, 2014 at 07:35:39PM +0000, Joseph S. Myers wrote:
> ARM has an override of the test math/test-fpucw.c, to disable (for
> soft-float testing) definitions of hard-float macros in fpu_control.h
> that the header normally defines not only when building for
> hard-float, but also when building for soft-float with _LIBC defined
> so that libc code can dynamically test whether VFP hardware is
> present.  (_LIBC is defined when building tests, although ideally it
> wouldn't be.)
> 
> The override doesn't work for the derived tests test-fpucw-*.c because
> they use #include "" instead of <> to include test-fpucw.c, so always
> get the math/ version instead of the ARM sysdeps override.  This patch
> changes them to use <> so the sysdeps override is effective.
> (test-fpucw-ieee-static.c doesn't need a change because it includes
> test-fpucw-ieee.c, which isn't itself being overridden, which in turn
> includes test-fpucw.c with a #include changed by this patch.)
> 
> Tested for ARM (big-endian soft-float, non-VFP hardware).
> 
> 2014-01-15  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* math/test-fpucw-ieee.c: Use <> in #include of test-fpucw.c.
> 	* math/test-fpucw-static.c: Likewise.
> 

Looks OK to me.

Thanks,
Siddhesh



More information about the Libc-alpha mailing list