[PATCH][BZ #16453] Don't use alloca in addgetnetgrentX

[Ondřej Bílka]

On Wed, Jan 15, 2014 at 10:45:22AM -0500, Carlos O'Donell wrote:
> On 01/15/2014 10:32 AM, Siddhesh Poyarekar wrote:
> > On 15 January 2014 20:57, Mike Frysinger <vapier@gentoo.org> wrote:
> >> On Wednesday 15 January 2014 06:34:52 Siddhesh Poyarekar wrote:
> >>> The bug report has a reproducer and I verified that the reproducer is
> >>> fixed with this patch.  OK to commit?
> >>
> >> is there no way for us to set up local paths for networking files specifically
> >> for testing purposes ?  seems like a pretty big hole in our testing abilities.
> >>
> > 
> > The paths are hardcoded, which is why this is difficult and because of
> > that, nscd testing is essentially a noop.  The chroot-based testing
> > framework that Ryan is working on will help this quite a bit.
> > 
> >>> +                                 buflen = MAX (2 * buflen,
> >>> +                                               buflen + 2 * needed);
> >>> +                                 char *newbuf = xrealloc (buffer, buflen);
> >>> +                                 buffer = newbuf;
> >>


If we are at simplyfing buflen could be written as 

                                 buflen = buflen + MAX (buflen, 2 * needed)

to fit a line.