[PING^2][PATCH] Reformat malloc to gnu style.
Ondřej Bílka
neleai@seznam.cz
Fri Jan 10 13:35:00 GMT 2014
On Thu, Jan 09, 2014 at 04:52:28PM +0530, Siddhesh Poyarekar wrote:
> On Thu, Jan 02, 2014 at 07:55:09PM +0100, OndÅej BÃlka wrote:
> > That is missing a point, a formatting now was wastly different than gnu
> > one so goal was not get perfect on first try but to converge to
> > solution.
> >
> > In formatting patches there are three factors in play:
> >
> > 1) Amount of code formatted correctly.
> > 2) Amount of code left intact.
> > 3) Amount of code formatted incorrectly.
> >
> > Now factors 2 and 3 sum to amount of code that needs futher formatting.
> > If a formatter gets 95% of code right then you need to fix only 5% of
> > code which means that patches that fix these are twenty times smaller
> > than in first case.
> >
> > For our purposes it is mostly irrelevant if flaw was caused by formatter
> > or left over unless formatting causes loss of informattion. Where a style
> > allows only one possibility you cannot encode any information so that is
> > not a factor.
>
> Ondrej, did you get a chance to work on further fixes to formatting in
> malloc? I noticed during a rawhide rebase that a number of macros
> remain incorrectly formatted. It would be nice to have a consistently
> formatted malloc in 2.19.
>
Ok, I will send these probably tommorow.
More information about the Libc-alpha
mailing list