i686/memmove.S always copies backwards when dst > src

Maxim Kuvyrkov maxim@kugelworks.com
Tue Jan 7 19:20:00 GMT 2014


On 8/01/2014, at 7:23 am, Ondřej Bílka <neleai@seznam.cz> wrote:

> On Tue, Jan 07, 2014 at 02:20:47PM +1300, Maxim Kuvyrkov wrote:
...
>> 
>> I've created BZ #16394.  The attached patch was tested in i686 environment with memmove ifunc forced to resolve to implementation in sysdeps/i386/i686/memmove.S.
>> 
>> I will check in the patch in 24 hours since at least 3 developers have looked at it and confirmed that it is the right fix.
>> 
>> Thanks,
>> 
> As I said above it looks correct, who else?

You, Yuriy and myself.  Also, I've spent a good deal of time in the debugger to confirm that the bug cannot trigger wrong behavior, and managed to convince myself of that.

Thanks,

--
Maxim Kuvyrkov
www.kugelworks.com



More information about the Libc-alpha mailing list