[PATCH 2/*] Expand arena_get macro.

Siddhesh Poyarekar siddhesh@redhat.com
Fri Feb 21 14:04:00 GMT 2014


On Fri, Feb 21, 2014 at 01:02:57PM +0100, Ondřej Bílka wrote:
> Simple in lockless implementation you want to get arena but not lock it.
> As macros are now they decrease readibility, you cannot use arena_lookup
> directly as it may be null so you would duplicate a arena_lock casing
> anyway, relevant macros are:

We don't have a lockless implementation right now.  IMO this change
might be more suitable as a precursor patch for a lockless
implementation when there is actually a patch for it which shows that
the macro removal is actually needed.

It's an opinion of course, since the macro expansion doesn't actually
change behaviour - it does affect QoI IMO, but that again is an
opinion.  If nobody else thinks this change needs more justification
then I don't think my opposition would be valid.

Siddhesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140221/31a4d537/attachment.sig>


More information about the Libc-alpha mailing list