[PATCH] Allow inclusion of sysdep.h and sys/auxv.h at build time

Carlos O'Donell carlos@redhat.com
Thu Feb 20 23:21:00 GMT 2014


On 02/20/2014 06:18 PM, Adam Conrad wrote:
> On Thu, Feb 20, 2014 at 06:14:14PM -0500, Carlos O'Donell wrote:
>>
>> This looks good to me, but I'm curious what this actually fixes?
> 
> elf/tst-auxv.c includes misc/sys/auxv.h, which ends up not actually
> being included due to the guard overlap, and getauxval becomes an
> implicit declaration and implicit pointer conversion which means, at
> best, the test isn't actually testing what it thinks it is and, at
> worst, it'll crash and burn on platforms where implict pointer
> conversion is a Very Bad Thing.

Excellent answer. Please include that kind of rationale in the
original patch next time :-)

OK to checkin. It's a bit crufty, but I don't see an easy way
around it.

Cheers,
Carlos.



More information about the Libc-alpha mailing list