[PATCH] Remove nested function in elf/dl-lookup.c.

Ondřej Bílka neleai@seznam.cz
Wed Feb 19 13:06:00 GMT 2014


On Wed, Feb 12, 2014 at 04:27:40PM -0500, Carlos O'Donell wrote:
> On 02/12/2014 03:50 PM, Joseph S. Myers wrote:
> > This patch loses the call to ELF_MACHINE_SYM_NO_MATCH that was previously 
> > in check_match, and also needs to update the comment on the default 
> > definition of ELF_MACHINE_SYM_NO_MATCH to reflect that check_match is no 
> > longer a nested function.
> 
> I have thrown away the existing refactoring and started again,
> and then compared my new version to the old version to ensure
> that previous testing would still be valid.
> 
> This should catch any changes since the last time I refactored.
> I had included Ondrej's changes but had not noticed your changes.
> Git had given me a merge warning for Ondrej's changes for
> __glibc_*likely, but not yours, perhaps I did something wrong there.
> 
> Either way I've rested the following and it looks good.
> 
> OK?
> 
I am ok with this.



More information about the Libc-alpha mailing list