[PATCH v1.1] Deduplicate resolv/nss_dns/dns-host.c

Mike Frysinger vapier@gentoo.org
Sun Feb 16 01:30:00 GMT 2014


On Saturday, February 15, 2014 12:39:19 Ondřej Bílka wrote:
> On Fri, Feb 14, 2014 at 12:25:51PM -0500, Mike Frysinger wrote:
> > On Thursday, February 13, 2014 13:38:12 Ondřej Bílka wrote:
> > > Hi, when reviewing Andreas patch I noticed duplicated code. One way to
> > > improve that is jump to exit logic. A second possibility would be put
> > > 
> > >  gaih_getanswer into a else block. What do you prefer?
> > 
> > i don't mind either, but i think generally the preference is to avoid goto
> > when easily possible.  so in this case, use the else.
> > -mike
> 
> OK, patch for this is following. It should cover one extra possibility when
> __libc_res_nsearch fails and allocates separate buffer.

OK
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140216/2f4a5aab/attachment.sig>


More information about the Libc-alpha mailing list