[PATCH] Added missing ICMPv6 flags and option

[Florian Weimer]

On 02/12/2014 10:14 PM, Carlos O'Donell wrote:
> On 02/12/2014 03:52 PM, Florian Weimer wrote:
>> On 02/12/2014 09:25 PM, Carlos O'Donell wrote:
>>
>>> I'll let Florian comment on the other points.
>>
>> I already replied offlist:
>>
>> I looked a bit around and it seems the BSDs already have these
>> constants under slightly different names, ND_RA_FLAG_RTPREF_LOW etc.,
>> plus _MASK and _RSV constants.  This might be sufficient reason to
>> include these constants.
>
> Right, we need a standard set of defines.
>
> Do these constants exist in the Linux kernel?

Not as far as I can tell.

> Would a sensible person reading the RFCs come up with the same constant names?

This seems fairly unlikely.  RFC 4191 does not use symbolic constants at 
all.

-- 
Florian Weimer / Red Hat Product Security Team