Make ABI tests generate .out files

Carlos O'Donell carlos@redhat.com
Wed Feb 12 20:14:00 GMT 2014


On 02/12/2014 01:34 PM, Joseph S. Myers wrote:
> If you rerun "make check" in a tree where some tests have already been
> run, it will rerun ABI tests because those do not create an output
> file.
> 
> This patch changes those tests to create .out files so they only get
> rerun if the dependencies (on the ABI baselines and the generated
> .symlist files) indicate they should be rerun.
> 
> Tested x86_64.
> 
> (The ChangeLog entry explicitly says "target" and "variable" to avoid
> confusion with there being entries for both a target called check-abi
> and a variable called check-abi.)
> 
> 2014-02-12  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* Makerules (check-abi-%): Change target to
> 	$(objpfx)check-abi-%.out.
> 	(check-abi target): Update dependencies.
> 	(check-abi-pattern variable): Redirect output of diff to $@.
> 	(check-abi variable): Likewise.
> 	* elf/Makefile (check-abi): Update dependencies.

Looks good to me. Fairly mechanical.

Cheers,
Carlos.



More information about the Libc-alpha mailing list