[PING] [PATCH] i686: Fix test suite fails on build by gcc 5.0

[H.J. Lu]

On Tue, Dec 30, 2014 at 10:31 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Dec 29, 2014 at 5:45 AM, Senkevich, Andrew
> <andrew.senkevich@intel.com> wrote:
>> 2014-11-27 20:23 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>>> We should also undef SETUP_PIC_REG_STR and LOAD_PIC_REG_STR in
>>> sysdeps/i386/sysdep.h for GCC 5, which are defined for C sources and
>>> will be wrong for GCC 5.
>>
>> Attached patch formatted for git am.
>>
>> ChangeLog:
>>
>> 2014-12-29  Andrew Senkevich  <andrew.senkevich@intel.com>
>>
>>         * sysdeps/i386/tls-macros.h (TLS_IE, TLS_LD, TLS_GD): Keep define in
>>         PIC mode only if gcc version < 5.0
>>         * sysdeps/i386/sysdep.h (SETUP_PIC_REG_STR, LOAD_PIC_REG_STR): Keep
>>         define only if gcc version < 5.0
>
> Do we really need to change SETUP_PIC_REG_STR and
> LOAD_PIC_REG_STR? SETUP_PIC_REG_STR is only used
> in LOAD_PIC_REG_STR and LOAD_PIC_REG_STR is only used
> in check_consistency.  I think check_consistency change is
> sufficient.
>
>>         * sysdeps/unix/sysv/linux/i386/sysdep.h (check_consistency): Likewise.
>>
>> Is it Ok?
>>

This is the patch I checked in.

Thanks.

-- 
H.J.
---
2014-12-30  Andrew Senkevich  <andrew.senkevich@intel.com>

* sysdeps/i386/tls-macros.h: Include <features.h>.
(TLS_LE): Use non-PIC version for GCC >= 5.0.
(TLS_IE): Likewise.
(TLS_LD): Likewise.
(TLS_GD): Likewise.
* sysdeps/unix/sysv/linux/i386/sysdep.h (check_consistency): Don't
define for GCC >= 5.0.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-i386-Fix-build-by-GCC-5.0.patch
Type: text/x-patch
Size: 2939 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141230/a954f002/attachment.bin>