fix -Werror regressions with gcc 4.8 on x86_64

[Joseph Myers]

On Tue, 23 Dec 2014, Alexandre Oliva wrote:

> On Dec 23, 2014, Alexandre Oliva <aoliva@redhat.com> wrote:
> 
> > Here's a patch that fixes a few build errors I got when using GCC 4.8
> > with -Werror.  Ok to install?
> 
> And here are a few more that I only hit when running the testsuite...
> Ok to install?

Are you building with -DNDEBUG?  That's the only way I can see these 
variables being unused (set-but-not-used).  NDEBUG is definitely a broken 
configuration for running the testsuite, as it means tests aren't checking 
what they should if the verification uses assert - the warnings are 
showing up a problem with your environment, not with glibc (see what 
Roland said in 
<https://sourceware.org/ml/libc-alpha/2014-12/msg00589.html>).  And I'm 
doubtful NDEBUG is a sensible configuration for building glibc itself 
either; at least, it's not a well-tested one.

Thus, this patch seems wrong, and I'm dubious of the previous patch 
without a clean consensus to support NDEBUG builds of glibc.

-- 
Joseph S. Myers
joseph@codesourcery.com