[Patch, MIPS] Modify memset.S for mips32r6/mips64r6

Matthew Fortune Matthew.Fortune@imgtec.com
Sat Dec 20 07:40:00 GMT 2014


Joseph Myers <joseph@codesourcery.com> writes:
> On Fri, 19 Dec 2014, Matthew Fortune wrote:
> 
> > > +#if __mips_isa_rev > 5
> >
> > I've just so happened to be starting some mips2 tests with glibc and
> > found see that __mips_isa_rev is not defined below mips32.
> > This is then an error given -Werror is in force.
> 
> We still have -Wno-error=undef, so it *shouldn't* be an error (but once
> Siddhesh's remaining -Wundef fixes are in, and any further fixes needed
> to get clean for -Wundef in at least one configuration, we should remove
> -Wno-error=undef, so such issues certainly need fixing soon).

Ah, OK. I think my build must have failed for a different reason
and there was __mips_isa_rev warning close to the end that I
misread as an error.

I guess we can leave it to a cleanup commit for all the instances
then.

Matthew



More information about the Libc-alpha mailing list