question about env and function malloc

[Alexandre Oliva]

[Cc:ing the list]

On Dec 17, 2014, MaShimiao <mashimiao.fnst@cn.fujitsu.com> wrote:

> But, the description of env in glibc manual says if a function accesses 
> environment with getenv() of similar, without any guard, then it should be
> marked with env. it doesn't mention any special functions.
> Do you think we should add some words to remind users that there are some special
> conditions in which even a function calls getenv(), it will not be marked with env.
> Just like malloc() or free().
> Or we just add explanations in the description of each special functions?

I think a note at the exception point should be enough, as in the patch
below.

Ok to install?


for ChangeLog

	* manual/memory.texi (malloc): Elaborate rationale to drop
	@mtsenv from malloc_printerr.
---
 manual/memory.texi |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/manual/memory.texi b/manual/memory.texi
index 0729e70..03242c3 100644
--- a/manual/memory.texi
+++ b/manual/memory.texi
@@ -376,9 +376,9 @@ this function is in @file{stdlib.h}.
 @c   fastbin_index ok
 @c   fastbin ok
 @c   catomic_compare_and_exhange_val_acq ok
-@c   malloc_printerr dup @mtsenv
-@c     if we get to it, we're toast already, undefined behavior must have
-@c     been invoked before
+@c   malloc_printerr dup ok [no @mtsenv, see below]
+@c     if we get to malloc_printerr, undefined behavior must have been
+@c     invoked, so don't bother propagating @mtsenv up the call chain
 @c    libc_message @mtsenv [no leaks with cancellation disabled]
 @c     FATAL_PREPARE ok
 @c      pthread_setcancelstate disable ok


-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer