[PATCH] Simplify strncat.

Ondřej Bílka neleai@seznam.cz
Wed Dec 17 16:32:00 GMT 2014


On Tue, Dec 16, 2014 at 12:36:38PM -0800, Roland McGrath wrote:
> Use '\0', not '\000'.
> 
> IIRC we have a general policy about having a benchtests case and citing
> numbers on that.

That is not policy as benchtest results on string function are still
meaningless. Here I could simply improve benchtest score by inlining
strnlen and memcpy implementations, for example with

#define memcpy memcpy2
#include <string/memcpy.c>

As it avoids call overhead. However it would be big mistake to do that
"optimization" as strncat is cold function while memcpy is likely in
memory it degrade performance due to additonal icache misses.



More information about the Libc-alpha mailing list