[PATCH] Fix 'array subscript is above array bounds' warning in res_send.c

Siddhesh Poyarekar siddhesh@redhat.com
Tue Dec 16 10:09:00 GMT 2014


Hi,

I see this warning in my build on F21 x86_64, which seems to be due to
a weak check for array bounds.  Fixed by making the bounds check
stronger.

OK to commit?

Siddhesh

	* resolv/res_send.c (__libc_res_nsend): Fix check for nsmap
	bounds.

diff --git a/resolv/res_send.c b/resolv/res_send.c
index 4a95eb8..5a9882c 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -429,7 +429,7 @@ __libc_res_nsend(res_state statp, const u_char *buf, int buflen,
 				while (ns < MAXNS
 				       && EXT(statp).nsmap[ns] != MAXNS)
 					ns++;
-				if (ns == MAXNS)
+				if (ns >= MAXNS)
 					break;
 				EXT(statp).nsmap[ns] = n;
 				map[n] = ns++;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141216/e33abe47/attachment.sig>


More information about the Libc-alpha mailing list