[COMMITTED PATCH] Fix -Wformat-security warnings in posix/regexbug1.c

Roland McGrath roland@hack.frob.com
Thu Dec 11 21:13:00 GMT 2014


2014-12-11  Roland McGrath  <roland@hack.frob.com>

	* posix/regexbug1.c (main): Use "%s" format with regerror results,
	rather than assuming they won't contain any '%'s.

--- a/posix/regexbug1.c
+++ b/posix/regexbug1.c
@@ -18,7 +18,7 @@ main (void)
     {
       char buf[100];
       regerror (reerr, &re, buf, sizeof buf);
-      error (EXIT_FAILURE, 0, buf);
+      error (EXIT_FAILURE, 0, "%s", buf);
     }
 
   if (regexec (&re, "002", 2, ma, 0) != 0)
@@ -35,7 +35,7 @@ main (void)
     {
       char buf[100];
       regerror (reerr, &re, buf, sizeof buf);
-      error (EXIT_FAILURE, 0, buf);
+      error (EXIT_FAILURE, 0, "%s", buf);
     }
 
   if (regexec (&re, "002", 2, ma, 0) != 0)



More information about the Libc-alpha mailing list