[PATCH] fix to malloc checking

[Andreas Schwab]

James Lemke <jwlemke@codesourcery.com> writes:

> On 11/26/2014 04:40 AM, Will Newton wrote:
>> This looks ok to me, although there are some minor style issues, e.g.:
>>
>> There should be a space after casts.
>> There's a bracket on its own that should be moved onto the line above.
>> A couple of if statements have some leading space that should not be there.
>
> Thanks for the review.  This version fixes the style issues above.
> Unless anyone has other issues I will commit this version.

This is broken, please revert.

$ MALLOC_CHECK_=3 iconv/iconvconfig --prefix=$PWD/root
*** Error in `iconv/iconvconfig': free(): invalid pointer: 0x09f15018 ***
======= Backtrace: =========
/suse/schwab/src/libc/i586/libc.so.6(+0x6cd73)[0xf7691d73]
/suse/schwab/src/libc/i586/libc.so.6(+0x72933)[0xf7697933]
/suse/schwab/src/libc/i586/libc.so.6(cfree+0x9b)[0xf769b31b]
/suse/schwab/src/libc/i586/libc.so.6(+0x2acea)[0xf764fcea]
/suse/schwab/src/libc/i586/libc.so.6(+0x23f35)[0xf7648f35]
/suse/schwab/src/libc/i586/libc.so.6(setlocale+0x2cf)[0xf76487af]
iconv/iconvconfig[0x8048dd5]
/suse/schwab/src/libc/i586/libc.so.6(__libc_start_main+0xf3)[0xf763e6f3]
iconv/iconvconfig[0x8049a96]
======= Memory map: ========
08048000-0804f000 r-xp 00000000 08:03 50072439                           /daten/src/libc/i586/iconv/iconvconfig
0804f000-08050000 r--p 00006000 08:03 50072439                           /daten/src/libc/i586/iconv/iconvconfig
08050000-08051000 rw-p 00007000 08:03 50072439                           /daten/src/libc/i586/iconv/iconvconfig
09f15000-09f36000 rw-p 00000000 00:00 0                                  [heap]
f75db000-f75f6000 r-xp 00000000 08:02 1319905                            /lib/libgcc_s.so.1
f75f6000-f75f7000 r--p 0001a000 08:02 1319905                            /lib/libgcc_s.so.1
f75f7000-f75f8000 rw-p 0001b000 08:02 1319905                            /lib/libgcc_s.so.1
f7623000-f7625000 rw-p 00000000 00:00 0 
f7625000-f7787000 r-xp 00000000 08:03 49819422                           /daten/src/libc/i586/libc.so
f7787000-f7789000 r--p 00161000 08:03 49819422                           /daten/src/libc/i586/libc.so
f7789000-f778a000 rw-p 00163000 08:03 49819422                           /daten/src/libc/i586/libc.so
f778a000-f778e000 rw-p 00000000 00:00 0 
f778e000-f778f000 r-xp 00000000 00:00 0                                  [vdso]
f778f000-f77af000 r-xp 00000000 08:03 50080584                           /daten/src/libc/i586/elf/ld.so
f77af000-f77b0000 r--p 0001f000 08:03 50080584                           /daten/src/libc/i586/elf/ld.so
f77b0000-f77b1000 rw-p 00020000 08:03 50080584                           /daten/src/libc/i586/elf/ld.so
ff8e7000-ff909000 rw-p 00000000 00:00 0                                  [stack]
Aborted

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."