[PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
Brad Hubbard
bhubbard@redhat.com
Tue Dec 9 22:48:00 GMT 2014
On 12/10/2014 08:33 AM, OndÅej BÃlka wrote:
> On Wed, Nov 05, 2014 at 02:44:34PM +0530, Siddhesh Poyarekar wrote:
>> On Wed, Nov 05, 2014 at 10:03:46AM +0100, Andreas Schwab wrote:
>>> Brad Hubbard <bhubbard@redhat.com> writes:
>>>
>>>> Following is the valgrind warning.
>>>>
>>>> ==26802== Conditional jump or move depends on uninitialised value(s)
>>>> ==26802== at 0x5343A25: svc_getreq_common (in /lib64/libc-2.5.so)
>>>
>>>> ==26802== by 0x534357B: svc_getreqset (in /lib64/libc-2.5.so)
>>>
>>> Why was svc_getreqset called with file descriptors that were never seen
>>> by xprt_register?
>>
>> That is likely an application bug, but it might not be a bad idea to
>> include the patch anyway. Failing the NULL check and returning seems
>> better than allowing to dereference arbitrary pointer values.
>>
> As its better to always fail than only sometimes I also think its good
> to include it.
>
Does anyone want me to follow up on the upstream bug?
Any advice on how best to do so? I assume a "ping" in the Bugzilla and the
mailing list but what format should they have (definite noob here but I want to
learn).
Any advice is greatly appreciated.
--
Kindest Regards,
Brad Hubbard
Senior Software Maintenance Engineer
Red Hat Global Support Services
Asia Pacific Region
More information about the Libc-alpha
mailing list