[RFC] [PATCH] Remove custom pthread_once implementation on sh.

Torvald Riegel triegel@redhat.com
Mon Dec 8 17:53:00 GMT 2014


This patch removes the custom implementation of pthread_once on sh.  I
have not tested this, but the generic implementation in
nptl/pthread_once.c works well on several architectures.

I don't claim to really understand sh assembly, but given that sh
defines no HW barriers it seems that the pthread_once fast path would
just be a normal load and a compiler barrier, which should be as fast in
C as in assembler.

Removing the custom implementation will ease maintenance.  If we decide
not to, I'd at least like to document why in the source of the custom
custom implementation.

Thoughts?  OK to commit?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: once-sh.patch
Type: text/x-patch
Size: 5854 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141208/cf60da1e/attachment.bin>


More information about the Libc-alpha mailing list