[PATCH v2] ftell: seek to end only when there are unflushed bytes (BZ #17647)

Andreas Schwab schwab@linux-m68k.org
Fri Dec 5 17:12:00 GMT 2014


Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:

> On 05-12-2014 14:23, Andreas Schwab wrote:
>> Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
>>
>>> @@ -364,11 +365,11 @@ do_ftell_test (const char *filename)
>>>              reading.  */
>>>           if (test_modes[i].fd_mode != O_WRONLY)
>>>             {
>>> -             char tmpbuf[data_len];
>>> +             char tmpbuf[data_len * char_len];
>> tmpbuf may not be aligned for wchar_t.
>
> But I can't see why this won't allocate enough space for further operations. 

Where did I say that?

> Care to explain?

Alignment and size are separate properties of an object.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Libc-alpha mailing list