[PATCH v2 1/2] [BZ #16141] strptime: extend %z range limits
James Perkins
james@loowit.net
Wed Dec 3 22:28:00 GMT 2014
On Wed, Dec 3, 2014 at 1:41 AM, Will Newton <will.newton@linaro.org> wrote:
> On 3 December 2014 at 02:27, James Perkins <james@loowit.net> wrote:
>> This is a fix for [BZ #16141] strptime %z offset restriction.
> The patch looks ok modulo the nit below. It would be good to add a test however.
I'm reworking it to add tests.
>> + /* valid range UTC-24 to +25, ala POSIX */
>
> The comment should be a sentence so start with a capital and end with
> a full-stop and a couple of spaces.
Thanks for the feedback, Will. In my rework I will also drop the range limit per
discussion with Paul Eggert, to honor a -9959 to +9959 input offset range,
so the comment will go away.
Cheers,
James
--
James Perkins <james@loowit.net> KN1X www.loowit.net/~james
2094 Arthur St, Eugene, OR 97405 +1.971.344.3969 mobile
More information about the Libc-alpha
mailing list