[PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
Florian Weimer
fweimer@redhat.com
Fri Aug 29 14:32:00 GMT 2014
On 08/29/2014 03:33 PM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
>> + if (__builtin_expect (rp2->start == 0xffff, 0) \
>
> Please use either this
>
>> + if (__builtin_expect (ch == 0xffff, 0) \
>
> or this consistently.
Oops, you are right. I went with the first variant, as in the original fix.
Retested successfully.
Allan, is this okay for master at this stage?
--
Florian Weimer / Red Hat Product Security
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-crashes-on-invalid-input-in-IBM-gconv-modules-BZ.patch
Type: text/x-patch
Size: 7289 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20140829/b5d5d824/attachment.bin>
More information about the Libc-alpha
mailing list