[PATCH v1.1] __gconv_translit_find: Actually append ".so" to module name [BZ #17187]

[Carlos O'Donell]

On 08/26/2014 08:25 AM, Florian Weimer wrote:
> On 08/26/2014 02:09 PM, Andreas Schwab wrote:
>> Florian Weimer <fweimer@redhat.com> writes:
>>
>>> +  /* This function always fails.  Transliteration module loading is
>>> +     not implemented.  */
>>> +  return 1;
>>
>> Since it always fails you can just remove the function completely.
> 
> If taken to the logical conclusion, this has a ripple effect and is not suitable for backporting:
> 
>   <https://sourceware.org/ml/libc-alpha/2014-08/msg00119.html>
> 
> So I had to stop somewhere, and I think the patch from last week is a reasonable compromise for backports and the 2.20 release.

Yes, and no. The ripple effect is still present in that all callers
must actually handle the function returning one instead of zero, thus
we still have to audit the callers. I tend to agree with Andreas
here, it's basically the same amount of audit work, *but* your smaller
patch will apply more easily to older branches, and reduces the
chance we have compiler/assembler/linker problems due to refactored
code.

Cheers,
Carlos.