[PATCH] Use statfs64() in shm_open() and posix_getpt().

[Andrew Pinski]

On Mon, Aug 4, 2014 at 5:49 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Mon 04 Aug 2014 15:51:15 Joseph S. Myers wrote:
>> On Sat, 2 Aug 2014, Mike Frysinger wrote:
>> > right, posix_openpt is part of libc, but shm_open is part of librt.  so
>> > the
>> > former should use __statfs64 to avoid the PLT while the latter should use
>> > statfs64.
>>
>> No, both should use __statfs64 as statfs64 is not part of the POSIX
>> namespace but shm_open is.  As previously discussed, PLT avoidance and
>> being namespace-clean are separate issues.
>
> why does that matter ?  statfs64 is always exported by libc and thus is in the
> visible ABI namespace.  i don't see why glibc's internals need to be concerned
> with conforming to POSIX at all -- they're internals.  what are you trying to
> cater to ?


A program can define a variable called statfs64 which is used instead
of the libc.so one when calling from librt.so.

Thanks,
Andrew Pinski


> -mike